Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid void type inference in let statements #438

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

Gusarich
Copy link
Member

Closes #436

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich added this to the v1.4.0 milestone Jun 18, 2024
@Gusarich Gusarich requested a review from anton-trunov June 18, 2024 22:05
CHANGELOG.md Show resolved Hide resolved
src/types/resolveStatements.ts Outdated Show resolved Hide resolved
@Gusarich Gusarich requested a review from anton-trunov June 19, 2024 08:12
@anton-trunov anton-trunov merged commit 9ed9193 into tact-lang:main Jun 19, 2024
3 checks passed
QwFRx added a commit to QwFRx/tact that referenced this pull request Jul 22, 2024
In Roadmap.md there was a line "let". The mistake is that the first letter in the sentence should be capitalized. 

I suggest fixing this problem by writing "Let" instead of "let".

Original:
"let-statements can now be used without an explicit type declaration and determine the type automatically if it was not specified: PR tact-lang#198 and PR tact-lang#438"
Improved:
"Let-statements can now be used without an explicit type declaration and determine the type automatically if it was not specified: PR tact-lang#198 and PR tact-lang#438"

Closes tact-lang#591

- [ ] I have updated CHANGELOG.md
- [ ] I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBER
- [ ] I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
- [ ] I have run all the tests locally and no test failure was reported
- [ ] I have run the linter, formatter and spellchecker
- [ ] I did not do unrelated and/or undiscussed refactorings
@QwFRx QwFRx mentioned this pull request Jul 22, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not allow inferring void type for let-bindings
2 participants