Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check getter name collisions in wrappers #556

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Check getter name collisions in wrappers #556

merged 5 commits into from
Jul 12, 2024

Conversation

Gusarich
Copy link
Member

Closes #547

  • I have updated CHANGELOG.md
  • I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBER
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich added this to the v1.4.1 milestone Jul 11, 2024
@Gusarich Gusarich requested a review from anton-trunov July 11, 2024 16:23
@anton-trunov anton-trunov self-assigned this Jul 12, 2024
@anton-trunov anton-trunov merged commit 540f2d3 into tact-lang:main Jul 12, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulyadav-57 rahulyadav-57 rahulyadav-57 approved these changes

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.

Conflict in TypeScript code generation for getter function with underscore
3 participants
@Gusarich @anton-trunov @rahulyadav-57