Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mostly accurate funcId representation #628

Merged
merged 5 commits into from
Jul 26, 2024
Merged

fix: mostly accurate funcId representation #628

merged 5 commits into from
Jul 26, 2024

Conversation

novusnota
Copy link
Member

@novusnota novusnota commented Jul 26, 2024

Closes #627

  • I have updated CHANGELOG.md
    - [ ] I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBER
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@novusnota novusnota requested a review from anton-trunov July 26, 2024 13:19
@anton-trunov anton-trunov added this to the v1.4.1 milestone Jul 26, 2024
@anton-trunov anton-trunov self-assigned this Jul 26, 2024
Also:
* made `funcId`-related tests in `test-failed/` to start with `funcid`
* replaced `.tact.tact` on some previous tests with `.tact`
@novusnota novusnota marked this pull request as ready for review July 26, 2024 14:18
@novusnota
Copy link
Member Author

One moment, I'll add some more negative tests

@anton-trunov
Copy link
Member

looks like we need a negative test with a hex number

Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@anton-trunov anton-trunov merged commit 4d68f4c into main Jul 26, 2024
3 checks passed
@anton-trunov anton-trunov deleted the issues/627 branch July 26, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

funcId in grammar.ohm of Tact doesn't match the possible range of identifiers and function names in FunC
2 participants