Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AST Comparison API #689

Merged
merged 26 commits into from
Aug 17, 2024
Merged

AST Comparison API #689

merged 26 commits into from
Aug 17, 2024

Conversation

jubnzv
Copy link
Member

@jubnzv jubnzv commented Aug 14, 2024 •
edited
Loading

Towards #686

  • I have updated CHANGELOG.md
  • I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBER
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

jubnzv added 22 commits August 14, 2024 08:14
@jubnzv
feat(grammar): Initial version of AstComparator
595909d 
Addresses tact-lang#686
@jubnzv
chore: prettier
44e70fd
@jubnzv
feat(tests): src/tests/formatting/propper → src/tests/contracts
d0c5eba
@jubnzv
feat(cmp): Introduce basic alpha renaming for top-level struct/messages
48251c8
@jubnzv
chore: Move spec files to the test directory
465af4a
@jubnzv
chore(tests): Generalize; extract common functionality
bb1049c
@jubnzv
feat(hash): Support all the AST nodes
a9c68fe
@jubnzv
chore(hash): public→private when needed
432ea80
@jubnzv
feat(renamer): Rename declarations of top-level elements
0537c0f
@jubnzv
fix: unused imports, formatting, spelling
6d607ef
@jubnzv
chore(cspell): typo
5878bb0
@jubnzv
chore: Remove src/test/contracts/pretty-printer-output/case-1.tact
696c28a
@jubnzv
feat(renamer): Rename native functions
16d16d6
@jubnzv
fix(rename+cmp): Rename only whole modules
87e12b9
@jubnzv
fix(tests): Formatter test
07ad262
@jubnzv
chore: Upload updated test
cf57f6e
@jubnzv
fix: ESLint warnings
bd8a710
@jubnzv
fix: cspell
436840a
@jubnzv
fix: knip
d259608
@jubnzv
chore: Update CHANGELOG
eb7e032
@jubnzv
feat(rename+sort): Sort attributes if requested
9c0f659
@jubnzv
chore(sort): Fix eslint warning
d400207 
It should be structured that way, because probably we'll need to add
some custom options to these `static` methods.
anton-trunov
anton-trunov requested changes Aug 17, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's fix merge conflicts and resolve a couple comments I left

cspell.json Outdated Show resolved Hide resolved
knip.json Outdated Show resolved Hide resolved
@anton-trunov anton-trunov added this to the v1.4.4 milestone Aug 17, 2024
@anton-trunov anton-trunov self-assigned this Aug 17, 2024
@jubnzv jubnzv marked this pull request as ready for review August 17, 2024 09:53
@anton-trunov anton-trunov merged commit 5281e44 into tact-lang:main Aug 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jubnzv @anton-trunov