Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional trailing semicolons for contract/trait items #718

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

anton-trunov
Copy link
Member

Closes #702

  • I have updated CHANGELOG.md
  • [ ] I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBER
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@anton-trunov anton-trunov added this to the v1.5.0 milestone Aug 22, 2024
@anton-trunov anton-trunov requested a review from novusnota August 22, 2024 04:55
@anton-trunov anton-trunov self-assigned this Aug 22, 2024
Copy link
Member

@Gusarich Gusarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about negative test cases?

@anton-trunov
Copy link
Member Author

It's hard to think of good negative tests here because this is about optional things. And ; between declarations are abundant in the codebase, serving some sort of negative cases

@anton-trunov anton-trunov merged commit 5089843 into main Aug 22, 2024
3 checks passed
@anton-trunov anton-trunov deleted the omit-more-semicolons branch August 22, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow omitting semicolons in contract/trait declarations and definitions
2 participants