Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ast): keep original base (hex, dec, oct, bin) for numerals #771

Merged
merged 4 commits into from
Aug 31, 2024
Merged

fix(ast): keep original base (hex, dec, oct, bin) for numerals #771

merged 4 commits into from
Aug 31, 2024

Conversation

anton-trunov
Copy link
Member

@anton-trunov anton-trunov commented Aug 31, 2024 •
edited
Loading

Issue

Closes #746 and closes #773.

Checklist

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@anton-trunov anton-trunov added this to the v1.5.0 milestone Aug 31, 2024
@anton-trunov anton-trunov self-assigned this Aug 31, 2024
jubnzv
jubnzv previously approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@jubnzv jubnzv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I would add a test that involves bignum, i.e., includes a number that exceeds the max value of the number type, to avoid regressions in the future.

@anton-trunov anton-trunov requested a review from jubnzv August 31, 2024 13:20
@anton-trunov
Copy link
Member Author

@jubnzv Great suggestion! I added a fix for too large message opcode

novusnota
novusnota approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@anton-trunov anton-trunov merged commit 32ff182 into main Aug 31, 2024
5 checks passed
@anton-trunov anton-trunov deleted the keep-numeral-format branch August 31, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novusnota novusnota novusnota approved these changes

@Gusarich Gusarich Awaiting requested review from Gusarich

@jubnzv jubnzv Awaiting requested review from jubnzv

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.5.0
3 participants
@anton-trunov @jubnzv @novusnota