Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(asm-functions): use multi-line strings in FunC and add some e2e tests #825

Merged
merged 2 commits into from
Sep 15, 2024
Merged

fix(asm-functions): use multi-line strings in FunC and add some e2e tests #825

merged 2 commits into from
Sep 15, 2024

Conversation

novusnota
Copy link
Member

@novusnota novusnota commented Sep 14, 2024 •
edited
Loading

Issue

Closes #824.

Checklist

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@novusnota novusnota requested a review from a team as a code owner September 14, 2024 22:07
@novusnota novusnota changed the title fix(asm-functions): use of multi-line strings in FunC and introduce proper e2e tests fix(asm-functions): use multi-line strings in FunC and introduce proper e2e tests Sep 14, 2024
@novusnota novusnota added this to the v1.5.0 milestone Sep 14, 2024
anton-trunov
anton-trunov requested changes Sep 15, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks a lot for catching it and improving the tests. Let's fix the changelog and merge it

CHANGELOG.md Outdated Show resolved Hide resolved
@anton-trunov anton-trunov changed the title fix(asm-functions): use multi-line strings in FunC and introduce proper e2e tests fix(asm-functions): use multi-line strings in FunC and add some e2e tests Sep 15, 2024
Gusarich
Gusarich previously approved these changes Sep 15, 2024
View reviewed changes
@anton-trunov anton-trunov merged commit a470488 into main Sep 15, 2024
5 checks passed
@anton-trunov anton-trunov deleted the closes-824 branch September 15, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

@Gusarich Gusarich Gusarich left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

Fift string literals ("...") in asm function blocks of Tact halt compilation of FunC
3 participants
@novusnota @anton-trunov @Gusarich