fix: reading module export item

tada5hi · Mar 10, 2023 · adf4115 · adf4115
1 parent 7e318f3
commit adf4115
Show file tree

Hide file tree

Showing 7 changed files with 62 additions and 51 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -11,9 +11,6 @@
     },
     "rules": {
         "class-methods-use-this": "off",
-        "import/no-cycle": [2, {
-            "maxDepth": 1
-        }],
         "no-shadow": "off",
         "no-use-before-define": "off",
 

diff --git a/src/loader/built-in/module/module.ts b/src/loader/built-in/module/module.ts
@@ -22,7 +22,7 @@ import {
     isObject,
 } from '../../../utils';
 import type { Loader } from '../../type';
-import type { ScriptFileLoadOptions } from './type';
+import type { ModuleLoadOptions } from './type';
 import { isJestRuntimeEnvironment, isTsNodeRuntimeEnvironment } from './utils';
 
 export class ModuleLoader implements Loader {
@@ -70,7 +70,7 @@ export class ModuleLoader implements Loader {
 
     async load(
         data: LocatorInfo | string,
-        options?: ScriptFileLoadOptions,
+        options?: ModuleLoadOptions,
     ) : Promise<unknown> {
         options = options || {};
         const [name, locatorInfo] = this.build(data, options);
@@ -132,7 +132,7 @@ export class ModuleLoader implements Loader {
 
     loadSync(
         data: LocatorInfo | string,
-        options?: ScriptFileLoadOptions,
+        options?: ModuleLoadOptions,
     ) : unknown {
         options = options || {};
         const [name, locatorInfo] = this.build(data, options);
@@ -174,7 +174,7 @@ export class ModuleLoader implements Loader {
 
     private build(
         data: LocatorInfo | string,
-        options: ScriptFileLoadOptions,
+        options: ModuleLoadOptions,
     ) : [string, LocatorInfo | undefined] {
         let name : string;
         let locatorInfo : LocatorInfo | undefined;

diff --git a/src/loader/built-in/module/type.ts b/src/loader/built-in/module/type.ts
@@ -7,12 +7,12 @@
 
 export type LoaderFilterFn = (key: string, value: unknown) => boolean;
 
-export type ScriptFileExportItem = {
+export type ModuleExport = {
     key: string,
     value: unknown
 };
 
-export type ScriptFileLoadOptions = {
+export type ModuleLoadOptions = {
     withExtension?: boolean,
     withFilePrefix?: boolean
 };
diff --git a/src/loader/built-in/module/utils.ts b/src/loader/built-in/module/utils.ts
@@ -5,6 +5,10 @@
  * view the LICENSE file that was distributed with this source code.
  */
 
+import { BaseError } from 'ebec';
+import { hasOwnProperty, isObject } from '../../../utils';
+import type { LoaderFilterFn, ModuleExport } from './type';
+
 export function isJestRuntimeEnvironment() : boolean {
     return process.env &&
         process.env.JEST_WORKER_ID !== undefined;
@@ -15,3 +19,47 @@ export function isTsNodeRuntimeEnvironment() : boolean {
     // @ts-ignore
     return !!process[Symbol.for('ts-node.register.instance')];
 }
+
+export function getModuleExport(
+    data: Record<string, any>,
+    filterFn?: LoaderFilterFn,
+): ModuleExport {
+    if (filterFn) {
+        const keys = Object.keys(data);
+        for (let i = 0; i < keys.length; i++) {
+            if (filterFn(keys[i] as string, data[keys[i] as string])) {
+                return {
+                    key: keys[i] as string,
+                    value: data[keys[i] as string],
+                };
+            }
+        }
+
+        throw new BaseError('Cannot find specific module export.');
+    }
+
+    let value: any;
+
+    if (
+        hasOwnProperty(data, '__esModule') &&
+        // eslint-disable-next-line no-underscore-dangle
+        !!data.__esModule &&
+        hasOwnProperty(data, 'default')
+    ) {
+        value = data.default;
+    } else {
+        value = data;
+    }
+
+    if (
+        isObject(value) &&
+        hasOwnProperty(value, 'default')
+    ) {
+        value = value.default;
+    }
+
+    return {
+        key: 'default',
+        value,
+    };
+}
diff --git a/src/loader/index.ts b/src/loader/index.ts
@@ -8,4 +8,3 @@
 export * from './built-in';
 export * from './helpers';
 export * from './module';
-export * from './utils';
diff --git a/src/loader/utils.ts b/src/loader/utils.ts
diff --git a/test/unit/loader.spec.ts b/test/unit/loader.spec.ts
@@ -9,7 +9,8 @@ import path from "node:path";
 import {
     load,
     loadSync,
-    getExportItem, LoaderManager
+    getModuleExport,
+    LoaderManager
 } from "../../src";
 import {LoaderId} from "../../src/loader/constants";
 
@@ -69,7 +70,7 @@ describe('src/loader/**', () => {
         const filePath = path.join(basePath, 'file.js');
 
         let loaderContent = await load(filePath) as Record<string, any>;
-        loaderContent = getExportItem(loaderContent);
+        loaderContent = getModuleExport(loaderContent);
         expect(loaderContent).toBeDefined();
         expect(loaderContent.key).toEqual('default');
         expect(loaderContent.value).toEqual({foo: 'bar'});
@@ -79,7 +80,7 @@ describe('src/loader/**', () => {
         const filePath = path.join(basePath, 'file.js');
 
         let loaderContent = loadSync(filePath) as Record<string, any>;
-        loaderContent = getExportItem(loaderContent);
+        loaderContent = getModuleExport(loaderContent);
         expect(loaderContent).toBeDefined();
         expect(loaderContent.key).toEqual('default');
         expect(loaderContent.value).toEqual({foo: 'bar'});
@@ -97,7 +98,7 @@ describe('src/loader/**', () => {
         const filePath = path.join(basePath, 'file-ts.ts');
 
         let loaderContent = await load(filePath) as Record<string, any>;
-        loaderContent = getExportItem(loaderContent);
+        loaderContent = getModuleExport(loaderContent);
         expect(loaderContent).toBeDefined();
         expect(loaderContent.key).toEqual('default');
         expect(loaderContent.value).toEqual({bar: 'baz'});
@@ -115,7 +116,7 @@ describe('src/loader/**', () => {
         const filePath = path.join(basePath, 'file-ts.ts');
 
         let loaderContent = loadSync(filePath) as Record<string, any>;
-        loaderContent = getExportItem(loaderContent);
+        loaderContent = getModuleExport(loaderContent);
         expect(loaderContent).toBeDefined();
         expect(loaderContent.key).toEqual('default');
         expect(loaderContent.value).toEqual({bar: 'baz'});
@@ -125,7 +126,7 @@ describe('src/loader/**', () => {
         const filePath = path.join(basePath, 'file-many-ts.ts');
 
         let loaderContent = await load(filePath) as Record<string, any>;
-        loaderContent = await getExportItem(loaderContent, (key) => {
+        loaderContent = await getModuleExport(loaderContent, (key) => {
             return key === 'bar';
         }) as Record<string, any>;
 
@@ -138,7 +139,7 @@ describe('src/loader/**', () => {
         const filePath = path.join(basePath, 'file-many-ts.ts');
 
         let loaderContent = loadSync(filePath) as Record<string, any>;
-        loaderContent = getExportItem(loaderContent, (key) => {
+        loaderContent = getModuleExport(loaderContent, (key) => {
             return key === 'bar';
         }) as Record<string, any>;
         expect(loaderContent).toBeDefined();