Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile syntax for best practices #547

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Dockerfile syntax for best practices #547

wants to merge 1 commit into from

Conversation

bebehei
Copy link

@bebehei bebehei commented May 9, 2023

  • install packages before adding the content. This won't trash the caching layers
  • Have sorted lists
  • Use export instead of ARG for DEBIAN_FRONTEND

@bebehei
Update Dockerfile syntax for best practices
9488a0c 
- install packages before adding the content. This won't trash the
  caching layers
- Have sorted lists
- Use export instead of ARG for DEBIAN_FRONTEND
jeremyandrews
jeremyandrews requested changes May 10, 2023
View reviewed changes
Copy link
Member

@jeremyandrews jeremyandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall no problems, however the gaggle feature isn't supported anymore; please also remove this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyandrews jeremyandrews jeremyandrews requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bebehei @jeremyandrews