Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove empty if branch #560

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Conversation

jeremyandrews
Copy link
Member

  • Fixes clippy detected issue:
error: this `if` branch is empty
Error:     --> src/metrics.rs:2549:9
     |
2549 |         if self.hosts.len() == 1 {}
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can remove it: `self.hosts.len() == 1;`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_if
     = note: `-D clippy::needless-if` implied by `-D warnings`
  • Using git blame confirmed this was added during #342
  • This slipped in during that earlier PR, and is not necessary; simply removing

Copy link
Contributor

@alecsmrekar alecsmrekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jeremyandrews jeremyandrews merged commit 6a74aa2 into tag1consulting:main Aug 26, 2023
2 checks passed
@jeremyandrews jeremyandrews deleted the empty-if branch August 26, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants