Issue 429: Implement ItemsPerSecond #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LionsAd
reviewed
Jan 5, 2024
src/graph.rs
Outdated
|
|
||
| fn initialize_or_increment(&mut self, key: &str, second: usize, value: u32) -> u32 { | ||
| if !self.0.contains_key(key) { | ||
| self.0.insert(key.to_string(), TimeSeries::new()); |
There was a problem hiding this comment.
Maybe use the insert function here?
LionsAd
reviewed
Jan 5, 2024
LionsAd
reviewed
Jan 5, 2024
src/graph.rs
Outdated
| } | ||
|
|
||
| fn initialize_or_increment(&mut self, key: &str, second: usize, value: u32) -> u32 { | ||
| if !self.0.contains_key(key) { |
There was a problem hiding this comment.
Maybe adding that as a helper function and using here, would make sense, too?
LionsAd
reviewed
Jan 5, 2024
|
@LionsAd Thanks for the review, I pushed a new commit with the suggested fixes |
LionsAd
reviewed
Jan 14, 2024
LionsAd
reviewed
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves this issue: #429
This PR creates a new struct
ItemsPerSecondand some accompanying methods that encapsulate the logic of the underlying hash map.Note:
I had to use
#[allow(dead_code)]because for some reason the compiler would complain about dead code, even though the code is being used.