Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong key name reference in template definition #10

Merged
merged 1 commit into from
Jan 30, 2024
Merged

fix: wrong key name reference in template definition #10

merged 1 commit into from
Jan 30, 2024

Conversation

leonsteinhaeuser
Copy link
Contributor

@leonsteinhaeuser leonsteinhaeuser commented Jan 29, 2024 •
edited
Loading

Description

This PR fixes a problem related to an incorrect "value" key name. In previous versions, the template check in the first line checked if .Values.<chart-name>.serviceMonitor.enabled was set. .Values.<chart-name> is not a property in the values.yaml, which caused a problem during chart execution.

How Has This Been Tested?

  • helm create example && go run cmd/bootstrap/main.go ./example

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@leonsteinhaeuser leonsteinhaeuser self-assigned this Jan 29, 2024
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. fix Denotes a PR that fixes a problem or bug. labels Jan 29, 2024
@leonsteinhaeuser leonsteinhaeuser marked this pull request as ready for review January 29, 2024 19:39
@leonsteinhaeuser leonsteinhaeuser requested a review from a team as a code owner January 29, 2024 19:39
helgebonert
helgebonert approved these changes Jan 30, 2024
View reviewed changes
Copy link

@helgebonert helgebonert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonsteinhaeuser leonsteinhaeuser merged commit 731710b into main Jan 30, 2024
5 checks passed
@leonsteinhaeuser leonsteinhaeuser deleted the fix/value-key-name-reference branch January 30, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helgebonert helgebonert helgebonert approved these changes

Assignees

@leonsteinhaeuser leonsteinhaeuser

Labels
fix Denotes a PR that fixes a problem or bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonsteinhaeuser @helgebonert