Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: go template in go template syntax #6

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

leonsteinhaeuser
Copy link
Contributor

Description

Before the introduction of this fix, the rendered template looked like this appname-{{ (index .path.segments 1)-{{ index .path.segments 2 }} }}, which is not a valid syntax.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • See examples folder "example-{{ (index .path.segments 1) }}-{{ index .path.segments 2 }}"

Test Configuration:

  • Terraform version: v1.6.1
  • Module version: dirty

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@leonsteinhaeuser leonsteinhaeuser self-assigned this Oct 17, 2023
@leonsteinhaeuser leonsteinhaeuser requested a review from a team as a code owner October 17, 2023 08:39
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. fix Denotes a PR that fixes a problem or bug. labels Oct 17, 2023
@leonsteinhaeuser leonsteinhaeuser force-pushed the fix/syntax-go-template-in-go-template branch from 7dcc5b5 to 3c8c9bf Compare October 17, 2023 08:45
leonsteinhaeuser added 2 commits October 17, 2023 10:50
Signed-off-by: leonsteinhaeuser <leon.steinhaeuser@tagesspiegel.de>
Signed-off-by: leonsteinhaeuser <leon.steinhaeuser@tagesspiegel.de>
@leonsteinhaeuser leonsteinhaeuser force-pushed the fix/syntax-go-template-in-go-template branch from 3c8c9bf to e93a90e Compare October 17, 2023 08:51
@leonsteinhaeuser leonsteinhaeuser enabled auto-merge (squash) October 17, 2023 09:05
examples/main.tf Outdated Show resolved Hide resolved
Signed-off-by: leonsteinhaeuser <leon.steinhaeuser@tagesspiegel.de>
@leonsteinhaeuser leonsteinhaeuser merged commit 83ce7ad into main Oct 17, 2023
5 checks passed
@leonsteinhaeuser leonsteinhaeuser deleted the fix/syntax-go-template-in-go-template branch October 17, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Denotes a PR that fixes a problem or bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants