Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customize node ipv4 range #13

Merged
merged 7 commits into from
Feb 1, 2024

Conversation

leonsteinhaeuser
Copy link
Contributor

@leonsteinhaeuser leonsteinhaeuser commented Jan 31, 2024

Description

This feature allows us to customize the ipv4 node CIDR range. In the previous version 192.168.1.0/24 was preset, which can lead to conflicts with other ipv4 node ranges if more than one cluster is provisioned.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@leonsteinhaeuser leonsteinhaeuser self-assigned this Jan 31, 2024
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. feature Denotes a PR to implement a new feature. labels Jan 31, 2024
leonsteinhaeuser added 4 commits January 31, 2024 13:21
We now support the customization of the ipv4 node range or the specification of a network and subnet ID

Signed-off-by: leonsteinhaeuser <leon.steinhaeuser@tagesspiegel.de>
Signed-off-by: leonsteinhaeuser <leon.steinhaeuser@tagesspiegel.de>
Signed-off-by: leonsteinhaeuser <leon.steinhaeuser@tagesspiegel.de>
Signed-off-by: leonsteinhaeuser <leon.steinhaeuser@tagesspiegel.de>
@leonsteinhaeuser leonsteinhaeuser force-pushed the feat/customize-node-ipv4-range branch from 97b319b to ef63213 Compare January 31, 2024 12:22
Signed-off-by: leonsteinhaeuser <leon.steinhaeuser@tagesspiegel.de>
@leonsteinhaeuser leonsteinhaeuser force-pushed the feat/customize-node-ipv4-range branch from 2d9e77f to 666a320 Compare January 31, 2024 12:24
@leonsteinhaeuser leonsteinhaeuser marked this pull request as ready for review January 31, 2024 12:25
@leonsteinhaeuser leonsteinhaeuser requested a review from a team as a code owner January 31, 2024 12:25
main.tf Outdated Show resolved Hide resolved
Signed-off-by: leonsteinhaeuser <leon.steinhaeuser@tagesspiegel.de>
@leonsteinhaeuser leonsteinhaeuser force-pushed the feat/customize-node-ipv4-range branch from 39b51d7 to 3544bf3 Compare February 1, 2024 09:38
Signed-off-by: leonsteinhaeuser <leon.steinhaeuser@tagesspiegel.de>
@leonsteinhaeuser leonsteinhaeuser force-pushed the feat/customize-node-ipv4-range branch from 31dc0a8 to b230b7f Compare February 1, 2024 09:41
Copy link

@f-pietsch f-pietsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonsteinhaeuser leonsteinhaeuser merged commit fc83a08 into main Feb 1, 2024
5 checks passed
@leonsteinhaeuser leonsteinhaeuser deleted the feat/customize-node-ipv4-range branch February 1, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Denotes a PR to implement a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants