-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: customize node ipv4 range #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
feature
Denotes a PR to implement a new feature.
labels
Jan 31, 2024
We now support the customization of the ipv4 node range or the specification of a network and subnet ID Signed-off-by: leonsteinhaeuser <leon.steinhaeuser@tagesspiegel.de>
Signed-off-by: leonsteinhaeuser <leon.steinhaeuser@tagesspiegel.de>
Signed-off-by: leonsteinhaeuser <leon.steinhaeuser@tagesspiegel.de>
Signed-off-by: leonsteinhaeuser <leon.steinhaeuser@tagesspiegel.de>
leonsteinhaeuser
force-pushed
the
feat/customize-node-ipv4-range
branch
from
January 31, 2024 12:22
97b319b
to
ef63213
Compare
Signed-off-by: leonsteinhaeuser <leon.steinhaeuser@tagesspiegel.de>
leonsteinhaeuser
force-pushed
the
feat/customize-node-ipv4-range
branch
from
January 31, 2024 12:24
2d9e77f
to
666a320
Compare
f-pietsch
suggested changes
Feb 1, 2024
Signed-off-by: leonsteinhaeuser <leon.steinhaeuser@tagesspiegel.de>
leonsteinhaeuser
force-pushed
the
feat/customize-node-ipv4-range
branch
from
February 1, 2024 09:38
39b51d7
to
3544bf3
Compare
Signed-off-by: leonsteinhaeuser <leon.steinhaeuser@tagesspiegel.de>
leonsteinhaeuser
force-pushed
the
feat/customize-node-ipv4-range
branch
from
February 1, 2024 09:41
31dc0a8
to
b230b7f
Compare
f-pietsch
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature allows us to customize the ipv4 node CIDR range. In the previous version 192.168.1.0/24 was preset, which can lead to conflicts with other ipv4 node ranges if more than one cluster is provisioned.
Checklist