Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflow] enforce PR title format by GitHub Acions/workflows #1159

Closed
archibate opened this issue Jun 6, 2020 · 1 comment · Fixed by #1219
Closed

[workflow] enforce PR title format by GitHub Acions/workflows #1159

archibate opened this issue Jun 6, 2020 · 1 comment · Fixed by #1219
Labels
enhancement Make existing things or codebases better feature request Suggest an idea on this project good first issue A great chance for starters

Comments

@archibate
Copy link
Collaborator

Concisely describe the proposed feature
As mentioned in #1153, I merged a PR without a tag by accident: Fix "unclosed file" in "ti regression" (#1147).
It would be great if we could enforce PR to be tagged & first-word-uppercase by GitHub workflow.

Describe the solution you'd like (if any)
Add a job to .github/workflow/persubmit.yml. If someone is expert on GitHub Actions, please go ahead :)

Additional comments
About PR title rules, please see https://taichi.readthedocs.io/en/latest/contributor_guide.html#prtag

@archibate archibate added enhancement Make existing things or codebases better feature request Suggest an idea on this project good first issue A great chance for starters labels Jun 6, 2020
@archibate archibate changed the title [workflow] enforce PR titles by GitHub Acions/workflows [workflow] enforce PR title format by GitHub Acions/workflows Jun 6, 2020
@yuanming-hu
Copy link
Member

Great proposal. We should also enforce: if there are more than two tags, there should be exactly one space between different tags. E.g. [Lang] [ir].

Note that the uppercase condition should only be enforced when the first character is a letter (a-z, A-Z).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Make existing things or codebases better feature request Suggest an idea on this project good first issue A great chance for starters
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants