Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[workflow] Add a workflow to enforce PR title format #1219

Merged
merged 22 commits into from
Jun 13, 2020
Merged

[workflow] Add a workflow to enforce PR title format #1219

merged 22 commits into from
Jun 13, 2020

Conversation

archibate
Copy link
Collaborator

@archibate archibate commented Jun 11, 2020 •
edited
Loading

@archibate archibate requested a review from yuanming-hu June 11, 2020 10:01
@archibate archibate changed the title [skip ci] [workflow] Add a workflow to enforce PR title format [workflow] Add a workflow to enforce PR title format Jun 11, 2020
@archibate archibate changed the title [workflow] Add a workflow to enforce PR title format [workflow] add a workflow to enforce PR title format Jun 11, 2020
@archibate archibate changed the title [workflow] add a workflow to enforce PR title format [workflow][misc] Add a workflow to enforce PR title format Jun 11, 2020
@archibate archibate changed the title [workflow][misc] Add a workflow to enforce PR title format [workflow] Add a workflow to enforce PR title format Jun 11, 2020
@archibate archibate changed the title [workflow] Add a workflow to enforce PR title format [workflow] [misc] Add a workflow to enforce PR title format Jun 11, 2020
@archibate archibate changed the title [workflow] [misc] Add a workflow to enforce PR title format [workflow] Add a workflow to enforce PR title format Jun 11, 2020
@archibate archibate requested a review from k-ye June 11, 2020 10:11
k-ye
k-ye approved these changes Jun 11, 2020
View reviewed changes
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
@archibate archibate requested review from k-ye and rexwangcc June 11, 2020 15:49
rexwangcc
rexwangcc reviewed Jun 11, 2020
View reviewed changes
Copy link
Collaborator

@rexwangcc rexwangcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! It's extremely helpful to maintain a clean change-log! I left a few comments.

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
misc/check_pr_title.py Outdated Show resolved Hide resolved
misc/check_pr_title.py Outdated Show resolved Hide resolved
misc/check_pr_title.py Outdated Show resolved Hide resolved
misc/check_pr_title.py Outdated Show resolved Hide resolved
misc/prtags.txt Outdated Show resolved Hide resolved
misc/check_pr_title.py Outdated Show resolved Hide resolved
@archibate @rexwangcc
[skip ci] Apply suggestions from code review
271aad8 
Co-authored-by: Chengchen(Rex) Wang <14366016+rexwangcc@users.noreply.github.com>
@archibate archibate requested a review from rexwangcc June 12, 2020 05:56
k-ye
k-ye approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

docs/contributor_guide.rst Outdated Show resolved Hide resolved
@archibate @k-ye
[skip ci] Update docs/contributor_guide.rst
f89f8d7 
Co-authored-by: Ye Kuang <k-ye@users.noreply.github.com>
@archibate archibate added the LGTM label Jun 12, 2020
@archibate archibate merged commit c61c2c4 into taichi-dev:master Jun 13, 2020
@FantasyVR FantasyVR mentioned this pull request Jun 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-ye k-ye k-ye approved these changes

@yuanming-hu yuanming-hu Awaiting requested review from yuanming-hu

@taichi-gardener taichi-gardener Awaiting requested review from taichi-gardener

@rexwangcc rexwangcc Awaiting requested review from rexwangcc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[workflow] enforce PR title format by GitHub Acions/workflows
4 participants
@archibate @k-ye @rexwangcc @taichi-gardener