Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Show LLVM version on startup #1287

Closed
yuanming-hu opened this issue Jun 20, 2020 · 4 comments
Closed

[misc] Show LLVM version on startup #1287

yuanming-hu opened this issue Jun 20, 2020 · 4 comments
Assignees
Labels
feature request Suggest an idea on this project good first issue A great chance for starters welcome contribution

Comments

@yuanming-hu
Copy link
Member

yuanming-hu commented Jun 20, 2020

Concisely describe the proposed feature
Since we are now upgrading from LLVM 8.0.1 to LLVM 10.0.0, it would be good to show the LLVM version when Taichi starts. For example, the startup message could be

[Taichi] <dev mode>, supported archs: [...], commit b62337c9, LLVM 10.0.0, python 3.6.9

Describe the solution you'd like (if any)
Just export macros such as LLVM_VERSION_MAJOR using pybind11. E.g., see get_version_major:

m.def("get_version_major", get_version_major);

@yuanming-hu yuanming-hu added feature request Suggest an idea on this project welcome contribution good first issue A great chance for starters labels Jun 20, 2020
@archibate
Copy link
Collaborator

I think the start up could become too long now...
Maybe we should use a separate command ti diagnose to show valuable system information including but not limited to:

@yuanming-hu
Copy link
Member Author

I think the start up could become too long now...
Maybe we should use a separate command ti diagnose to show valuable system information including but not limited to:

That's a good point. I think we can show all info that does not need run-time detection in the startup message. Yes, it may seem a bit too long, but it helps us diagnose bug reports much easier (note that it's hard to ask users run ti diagnose before they raise bug reports... We'd better print the info by default.)

@archibate
Copy link
Collaborator

But wasn't LLVM version always 10.1 in release mode since it's built-in from CI?

@yuanming-hu
Copy link
Member Author

But wasn't LLVM version always 10.1 in release mode since it's built-in from CI?

Currently we support both llvm 8.0.1 and llvm 10.0.0.

Jenkins (Linux) uses llvm 10.0.0 and other buildbots use 8.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Suggest an idea on this project good first issue A great chance for starters welcome contribution
Projects
None yet
Development

No branches or pull requests

3 participants