Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Show LLVM version on startup #1294

Merged
merged 5 commits into from
Jun 20, 2020
Merged

[misc] Show LLVM version on startup #1294

merged 5 commits into from
Jun 20, 2020

Conversation

FantasyVR
Copy link
Collaborator

Related issue = #1287

[Click here for the format server]


Last pr is closed because I overwrite the master branch accidentally. Sorry about that.

@archibate , you are right. I shouldn't create pr using the master branch. Thanks for your reminder.

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! Just a few minor code format tips. Sorry for being nit-picking.

python/taichi/core/util.py Outdated Show resolved Hide resolved
taichi/common/core.cpp Outdated Show resolved Hide resolved
taichi/python/export_lang.cpp Outdated Show resolved Hide resolved
FantasyVR and others added 3 commits June 20, 2020 23:09
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jun 20, 2020

Codecov Report

Merging #1294 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1294   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files          18       18           
  Lines        3274     3274           
  Branches      616      616           
=======================================
  Hits         2774     2774           
  Misses        365      365           
  Partials      135      135           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4213973...c37bf43. Read the comment docs.

@yuanming-hu yuanming-hu merged commit ee9f28d into taichi-dev:master Jun 20, 2020
@FantasyVR FantasyVR mentioned this pull request Jun 24, 2020
Rullec pushed a commit to Rullec/taichi that referenced this pull request Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants