Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI auto formatter #2369

Closed
k-ye opened this issue May 27, 2021 · 2 comments
Closed

Fix CI auto formatter #2369

k-ye opened this issue May 27, 2021 · 2 comments
Assignees
@Leonz5288
Labels
feature request Suggest an idea on this project

Comments

@k-ye
Copy link
Member

k-ye commented May 27, 2021

Concisely describe the proposed feature

Trigger heavy CI tests only when specific keyworks are used in a PR

Describe the solution you'd like (if any)

Use existing Github Actions to detect specific keyword
@k-ye k-ye added the feature request Suggest an idea on this project label May 27, 2021
@k-ye k-ye added the engprod label May 27, 2021
@Leonz5288 Leonz5288 mentioned this issue May 27, 2021
Merged
@k-ye k-ye mentioned this issue May 27, 2021
Merged
@k-ye k-ye changed the title Trigger CI only when specific keyworks are used in a PR Fix CI auto formatter Jun 2, 2021
@k-ye k-ye mentioned this issue Jun 2, 2021
Merged
@Leonz5288 Leonz5288 mentioned this issue Jun 2, 2021
Merged
@k-ye k-ye mentioned this issue Jun 3, 2021
Closed
43 tasks
@k-ye k-ye closed this as completed Jun 7, 2021
@k-ye
Copy link
Member Author

k-ye commented Jun 7, 2021

We can now trigger auto format via /format

@xumingkuan
Copy link
Contributor

xumingkuan commented Jun 18, 2021 •
edited
Loading

65e8ec4 looks somewhat correct but horrible...

We shouldn't have formatted external code.

@k-ye k-ye mentioned this issue Jun 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Leonz5288 Leonz5288

Labels
feature request Suggest an idea on this project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@k-ye @xumingkuan @Leonz5288