Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add comment dispatch in pull request to support auto format #2392

Merged
merged 8 commits into from
Jun 2, 2021

Conversation

Leonz5288
Copy link
Contributor

@Leonz5288 Leonz5288 commented Jun 2, 2021

Related issue = #2369
Support comment triggered auto format now. Comment "/format" in your PR to trigger auto format.

[Click here for the format server]


Leonz5288 and others added 8 commits May 25, 2021 19:01

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Ye Kuang <k-ye@users.noreply.github.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Leonz5288 Leonz5288 requested a review from k-ye June 2, 2021 05:41
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@k-ye k-ye merged commit dd6980c into taichi-dev:master Jun 2, 2021
@k-ye
Copy link
Member

k-ye commented Jun 2, 2021

Actually, there are still a few issues:

  1. Let's restore the "code_format" job. The name is misleading. It means to "check" the code format, but won't do any modification (Better rename it to "Check Code Format")
  2. The actual build and test jobs should depend on the check code format job.

@k-ye k-ye mentioned this pull request Jun 7, 2021
@Leonz5288 Leonz5288 deleted the comment_trigger_format branch June 17, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants