-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove VectorType
and legacy loop vectorization
#4096
Comments
+1 on this. IIUC, VectorType was originally created for CPU vectorization, which is not in use for a long time. I'd suggest us to unify the representation of vector/matrix types using |
Currently our vectors/matrices correspond to |
When I searched for However, that pass is never really used; whenever it is used (that is, on |
I'm not sure if that legacy code (https://github.com/taichi-dev/taichi/blob/master/taichi/transforms/loop_vectorize.cpp) is useful for future CPU vectorization implementation. @k-ye @turbo0628 |
TensorType
and VectorType
VectorType
and legacy loop vectorization
There is a |
That one is for bit array vectorization as described in https://yuanming.taichi.graphics/publication/2021-quantaichi/quantaichi.pdf. |
For the purpose of reducing dev confusion, let's just remove it for now. We can always get back the code if necessary. |
@k-ye There are also code dealing with vector "width" (which is always |
I believe the vector width code is more or less dealing with quant rather than vectorization? @Hanke98 . If so, let's keep them. |
I changed the |
Since vectors are just 1-d tensors, can we merge these two datatypes?
The text was updated successfully, but these errors were encountered: