Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Werror for TI_WITH_CUDA_TOOLKIT=ON #5133

Closed
ailzhang opened this issue Jun 10, 2022 · 2 comments
Closed

Enable Werror for TI_WITH_CUDA_TOOLKIT=ON #5133

ailzhang opened this issue Jun 10, 2022 · 2 comments
Assignees
@feisuzhu
Labels
build Build related issues ci

Comments

@ailzhang
Copy link
Contributor

Performance benchmark job now uses gcc instead of clang-10 as host compiler. One blocker of moving to clang-10 is that we need to enable Werror when TI_WITH_CUDA_TOOLKIT is on. Once it's fixed we should use clang-10 for perf benchmark job as well.
@ailzhang ailzhang added ci build Build related issues labels Jun 10, 2022
@taichi-ci-bot taichi-ci-bot moved this to Untriaged in Taichi Lang Jun 10, 2022
@qiao-bo
Copy link
Contributor

qiao-bo commented Jun 11, 2022

this is possible to fix in code. IIUC, the cupti source code is copied into our repo and we can just eliminate warning in the source.

@victoriacity victoriacity moved this from Untriaged to Todo in Taichi Lang Jun 17, 2022
@feisuzhu feisuzhu moved this from Todo to In Progress in Taichi Lang Jun 20, 2022
feisuzhu added a commit to feisuzhu/taichi that referenced this issue Jun 21, 2022
@feisuzhu
[build] Fix -Werror errors for TI_WITH_CUDA_TOOLKIT=ON (taichi-dev#5133)
f326e99
@feisuzhu feisuzhu mentioned this issue Jun 21, 2022
Merged
feisuzhu added a commit to feisuzhu/taichi that referenced this issue Jun 23, 2022
@feisuzhu
[build] Fix -Werror errors for TI_WITH_CUDA_TOOLKIT=ON (taichi-dev#5133)
e190efb
qiao-bo pushed a commit that referenced this issue Jun 23, 2022
@feisuzhu
[build] Fix -Werror errors for TI_WITH_CUDA_TOOLKIT=ON (#5133) (#5216)
b1ba457
Repository owner moved this from In Progress to Done in Taichi Lang Jun 24, 2022
@feisuzhu feisuzhu reopened this Jun 24, 2022
@feisuzhu feisuzhu mentioned this issue Jun 24, 2022
Closed
@feisuzhu
Copy link
Contributor

issue irrelevant now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feisuzhu feisuzhu

Labels
build Build related issues ci
Projects
Taichi Lang
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@feisuzhu @ailzhang @qiao-bo