Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete SOA layout for vector/matrix ndarrays #5849

Closed
ailzhang opened this issue Aug 23, 2022 · 0 comments · Fixed by #6030
Closed

Delete SOA layout for vector/matrix ndarrays #5849

ailzhang opened this issue Aug 23, 2022 · 0 comments · Fixed by #6030
Assignees
@jim19930609
Labels
refactor Refactor of API or codebases
Milestone
v1.2.0

Comments

@ailzhang
Copy link
Contributor

Talked to @PENGUINLIONG and @YuCrazing that we don't seem to have a use case for this yet, but considering this layout is kinda an overhead implementation wise. Let's delete it for now and this can be added back pretty easily in the future.
@ailzhang ailzhang added the refactor Refactor of API or codebases label Aug 23, 2022
@ailzhang ailzhang added this to the v1.2.0 milestone Aug 23, 2022
@taichi-gardener taichi-gardener moved this to Untriaged in Taichi Lang Aug 23, 2022
@jim19930609 jim19930609 self-assigned this Aug 24, 2022
@jim19930609 jim19930609 moved this from Untriaged to Todo in Taichi Lang Aug 24, 2022
@jim19930609 jim19930609 mentioned this issue Sep 10, 2022
Merged
Repository owner moved this from Todo to Done in Taichi Lang Sep 15, 2022
jim19930609 added a commit that referenced this issue Sep 15, 2022
@jim19930609
[Lang] Deprecate SOA-layout for NdarrayMatrix/NdarrayVector (#6030)
31d8b59 
Related issue = fix #5849

After this PR, Ndarray support only one memory layout (ti.AOS), and user
will be no longer able to specify layout explicitly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jim19930609 jim19930609

Labels
refactor Refactor of API or codebases
Projects
Taichi Lang
Status: Done
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

[Lang] Deprecate SOA-layout for NdarrayMatrix/NdarrayVector jim19930609/taichi
2 participants
@ailzhang @jim19930609