Remove codegen for demoted operations #6134
Assignees
Labels
refactor
Refactor of API or codebases
Comments
strongoier
added a commit
that referenced
this issue
Sep 22, 2022
Issue: #6134 `floordiv` is already demoted and should not appear in codegen.
strongoier
added a commit
that referenced
this issue
Sep 26, 2022
### Brief Summary While I was removing redundant codegen for `shr` (#6134), I found that augmented assign for `sar` was accidentally calling `shr`, so I fixed it by the way. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
strongoier
added a commit
that referenced
this issue
Oct 8, 2022
Issue: #6141 (comment), #6134 ### Brief Summary In SPIR-V there's actually `OpBitFieldUExtract` which does the job of `BitExtractStmt` perfectly, so let's stop demoting `BitExtractStmt` and let codegen handle it with the best instruction(s).
Repository owner
moved this from In Progress
to Done
in Taichi Lang
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There's a mandatory
demote_operationspass (https://github.com/taichi-dev/taichi/blob/master/taichi/transforms/demote_operations.cpp) which demotes high-level operations into low-level ones so that there's no need to handle these high-level ones in codegen of different backends. Those legacy codegen should be removed to keep the codebase clean.pow()with an integer exponentfloordivbit_shrBitExtractStmtThe text was updated successfully, but these errors were encountered: