Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Opt] [refactor] Avoid throwing exceptions in alg_simp and let it support more types #1060

Merged
merged 4 commits into from
May 26, 2020
Merged

[Opt] [refactor] Avoid throwing exceptions in alg_simp and let it support more types #1060

merged 4 commits into from
May 26, 2020

Conversation

xumingkuan
Copy link
Contributor

Related issue = #1059 #656 #505

The return value of alg_simp is "Is the IR modified in this pass?" and will be utilized in full_simplify.

[Click here for the format server]

@xumingkuan xumingkuan changed the title [opt] [refactor] Avoid throwing exceptions in alg_simp and support more types [Opt] [refactor] Avoid throwing exceptions in alg_simp and let it support more types May 26, 2020
@xumingkuan xumingkuan requested a review from yuanming-hu May 26, 2020 00:55
yuanming-hu
yuanming-hu approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Given these patterns are recurring, it may make sense to implement a DelayedIRModifier class with functions such as delete and insert_before.

@xumingkuan xumingkuan merged commit 0e10326 into taichi-dev:master May 26, 2020
@xumingkuan xumingkuan deleted the alg-simp3 branch May 27, 2020 20:12
@yuanming-hu yuanming-hu mentioned this pull request May 31, 2020
Merged
@xumingkuan xumingkuan mentioned this pull request Jun 8, 2020
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanming-hu yuanming-hu yuanming-hu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xumingkuan @yuanming-hu