Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm] [sparse] Fix a memory leak bug in GC's free list on CPU #1079

Merged
merged 5 commits into from
May 30, 2020

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented May 29, 2020

@k-ye k-ye requested review from yuanming-hu and xumingkuan May 29, 2020 14:59
@k-ye
Copy link
Member Author

k-ye commented May 29, 2020

This isn't completely ready yet, because I want to merge #1078 first to eliminate all the test failures. But you can probably get a sense of where the problem is..

Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

taichi/runtime/llvm/internal_function.h Outdated Show resolved Hide resolved
tests/python/test_internal_func.py Outdated Show resolved Hide resolved
@k-ye k-ye marked this pull request as ready for review May 30, 2020 01:58
@k-ye k-ye requested a review from xumingkuan May 30, 2020 01:58
Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@k-ye
Copy link
Member Author

k-ye commented May 30, 2020

Thanks for the quick review!

FYI, later I'd like to make the InternalFuncStmt support simple arguments, then we can pass in things like ti.cpu, ti.gpu labels to the test function..

@k-ye k-ye changed the title [llvm] [sparse] Add a test to expose the problem in free list [llvm] [sparse] Fix a memory leak bug in GC's free list, CPU onlly May 30, 2020
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. I'll take a look at the CUDA memory allocator as well. Just one suggestion - feel free merge after that's applied (if that makes sense).

taichi/runtime/llvm/internal_function.h Outdated Show resolved Hide resolved
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
@k-ye k-ye changed the title [llvm] [sparse] Fix a memory leak bug in GC's free list, CPU onlly [llvm] [sparse] Fix a memory leak bug in GC's free list on CPU May 30, 2020
@yuanming-hu yuanming-hu merged commit 6f95a81 into taichi-dev:master May 30, 2020
@k-ye k-ye deleted the gc branch May 31, 2020 05:01
@yuanming-hu yuanming-hu mentioned this pull request May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants