-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[llvm] [sparse] Fix a memory leak bug in GC's free list on CPU #1079
Conversation
This isn't completely ready yet, because I want to merge #1078 first to eliminate all the test failures. But you can probably get a sense of where the problem is.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the quick review! FYI, later I'd like to make the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM. I'll take a look at the CUDA memory allocator as well. Just one suggestion - feel free merge after that's applied (if that makes sense).
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
Related issue = #1076
[Click here for the format server]