Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CUDA] [test] Improve portability and remove GC tests on CUDA for now #1090

Merged
merged 1 commit into from
May 31, 2020
Merged

[CUDA] [test] Improve portability and remove GC tests on CUDA for now #1090

merged 1 commit into from
May 31, 2020

Conversation

yuanming-hu
Copy link
Member

call_internal doesn't work on CUDA at this moment.

Related issue = #1076

[Click here for the format server]

@yuanming-hu yuanming-hu merged commit 9a3c4a8 into taichi-dev:master May 31, 2020
@yuanming-hu yuanming-hu mentioned this pull request May 31, 2020
Merged
@k-ye
Copy link
Member

k-ye commented Jun 2, 2020

BTW, the @ti.all_archs here is actually misleading. For example

taichi/taichi/runtime/llvm/internal_functions.h

Line 62 in 43e1da5

nodes->gc_serial();

Here, even if the test runs with arch=ti.cuda, it's still testing the CPU impl..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taichi-gardener taichi-gardener Awaiting requested review from taichi-gardener

@k-ye k-ye Awaiting requested review from k-ye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuanming-hu @k-ye