Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt] [refactor] [bug] Avoid throwing exceptions in whole_kernel_cse and fix a bug #1131

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

xumingkuan
Copy link
Contributor

Related issue = #1059

Fix a bug:

$1 = ...
$2 : if $1 {
  $3 = const [0]
} else {
  $4 = const [0]
}

This pass would move the first statements of both branches outside the clause and crash when checking if the last statements of both branches are the same.

[Click here for the format server]

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@xumingkuan xumingkuan merged commit e1c8e23 into taichi-dev:master Jun 4, 2020
@xumingkuan xumingkuan deleted the cse2 branch June 6, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants