Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lang] [IR] Fix bound checks with coordinate offsets #1143

Merged
merged 4 commits into from
Jun 5, 2020
Merged

[Lang] [IR] Fix bound checks with coordinate offsets #1143

merged 4 commits into from
Jun 5, 2020

Conversation

TH3CHARLie
Copy link
Collaborator

@TH3CHARLie
Copy link
Collaborator Author

TH3CHARLie commented Jun 4, 2020 •
edited
Loading

Two things I'd like to mention:

  • I run ti format before commit, besides my new changes, commit 022d3f4 has export_lang.cpp expression_ops.h needs formating. To keep this PR related, I skip them.

  • I'd like to write tests for this(either C++/Python) would work, I am not sure that if there are any existing ones or maybe I create some new ones. I'll add them to test_debug.py

@TH3CHARLie TH3CHARLie marked this pull request as draft June 4, 2020 15:41
@TH3CHARLie TH3CHARLie marked this pull request as ready for review June 4, 2020 16:07
@TH3CHARLie TH3CHARLie requested review from archibate and k-ye June 4, 2020 16:10
@TH3CHARLie TH3CHARLie added GAMES201 GAMES 201 students' wishlist ir IR related issues labels Jun 4, 2020
xumingkuan
xumingkuan reviewed Jun 4, 2020
View reviewed changes
Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a nit. Thanks!

taichi/transforms/check_out_of_bound.cpp Outdated Show resolved Hide resolved
@TH3CHARLie TH3CHARLie requested a review from xumingkuan June 5, 2020 04:25
xumingkuan
xumingkuan approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM now. Thanks!

@xumingkuan xumingkuan merged commit 1920b90 into taichi-dev:master Jun 5, 2020
@TH3CHARLie TH3CHARLie mentioned this pull request Jun 5, 2020
Open
6 tasks
@TH3CHARLie TH3CHARLie deleted the bound-checks-for-tensors-with-coordinate-offset branch June 5, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xumingkuan xumingkuan xumingkuan approved these changes

@yuanming-hu yuanming-hu Awaiting requested review from yuanming-hu

@archibate archibate Awaiting requested review from archibate

@k-ye k-ye Awaiting requested review from k-ye

Assignees
No one assigned
Labels
GAMES201 GAMES 201 students' wishlist ir IR related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TH3CHARLie @xumingkuan