-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[llvm] Cache llvm runtime bitcode to reduce start up time in dev mode #1144
Conversation
Feel free to say no without a reason if you don't like this, just give me a walk around to disable these redundant compiling process.. |
I think maybe we can add an environment variable
Thanks for everything you have done for Taichi :-) |
I'm fine with this approach. But why we neeed compile rtbc each time restart? Can we just let Makefile care this? |
Done, btw, I found no test about |
May I merge this now? I suck the compile time so much that I have to watch bilibili before a program starts, please approve me asap if you feel everything is ok now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Please feel free to merge once the wording suggestions are applied.
Done, btw, I found no test about @ (matmul) in linalg, is this intensional? Also note that z = z @ w seems to fail due to l-value problems.
Thanks for reporting this! We should add tests and make z = z @ w
work.
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
This PR has broken the CI, see:
Please be mindful of |
Sorry for breaking CI! Maybe I shouldn't add |
Hmm, my feeling is that it's a Travis CI problem, maybe their clang is stuck at a super old version? Currently the master branch compiles just fine on my local env. I found this post (https://stackoverflow.com/a/49600206/12003165):
+1... |
2 weeks ago I met with this problem as well. It seems that <filesystem>
this header can only be used directly on macOS 10.15 Catalina, instead of
my 10.14 Mojave. It's fully about the version.
Ye Kuang <notifications@github.com> 于2020年6月6日周六 下午3:52写道:
… Hmm, my feeling is that it's a Travis CI problem, maybe their clang is
stuck at a super old version? Currently the master branch compiles just
fine on my local env.
I found this post (https://stackoverflow.com/a/49600206/12003165):
<filesystem> used to be in <experimental/filesystem>, so maybe we need to
use that on Mac?
Maybe I shouldn't add [skip ci] on the last commit of before merge...
+1...
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1144 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEAYDGXQXDOA2AYIA3LNJZLRVHYT5ANCNFSM4NSZQVVA>
.
|
Thanks for the info. Yeah I saw that Travis CI is stilling using XCode 10.3, which only covers up to Mac 10.14.6 |
Related issue = close #875
I hate debugging script in dev mode, just because this huge long start up time compiling bitcode everytime I restart..
[Click here for the format server]