-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GUI] Add ti.GUI.EXIT event to close a window #1152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind to add this feature to cocoa following the win32&x11 as example itpr / iapr?
Of course :) (Unless there's someone on a Mac that's interested in this task?)
I can't close the window :( Hitting the "close" button has no effect. |
Sorry! It should works now. |
Interesting... |
How about this? |
Same behavior after the new commits...
|
It works!!! |
Great! I'll merge this for now once @yuanming-hu approves me, and please add a Mac version before Jun 7 we release v0.6.8 if someone feel interested :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Co-authored-by: xumingkuan <xumingkuan0721@126.com>
Related issue = #1118
[Click here for the format server]
@xumingkuan Could you do me a favor by testing this sample code:
when you have time? Many thanks :)
@k-ye Would you mind to add this feature to cocoa following the win32&x11 as example itpr / iapr? No rush at all, any time before v0.6.8 is ok :)