[metal] Add kernel side memory allocator #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanming-hu
approved these changes
Jun 10, 2020
k-ye
commented
Jun 10, 2020
| metal::memory_order_relaxed); | ||
| } | ||
|
|
||
| [[maybe_unused]] PtrOffset mtl_listmgr_ensure_chunk(thread ListManager *l, |
There was a problem hiding this comment.
Thanks! Honestly I think this mtl_listmgr_ensure_chunk is all that deserves some attention. It implements the memory allocation..
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has no functionality changes. It just reimplements Metal's
ListManagervia the dynamic memory allocator on the GPU. All the existing tests have passed, andtaichi_sparse.pyran just fine.The concrete design is listed in #1174 itself.
Related issue = #1174
[Click here for the format server]