[IR] Move "lower_access" after "offload" #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removing |
yuanming-hu
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
Thank you! LGTM.
Removing Simplify II here won't affect the resulting number of statements, but it looks weird to me not having full_simplify before offload.
We actually do want a simplification there: lower_access may lead to a lot of instruction that slows down future passes. It would be good to use Simlification II to reduce the number of instruction early before lower_access.
yuanming-hu
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR = #1180
In order to achieve similar performance, I added some optimization passes.
[Click here for the format server]