Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm] [opt] CSE for LoopIndexStmt #1203

Merged
merged 2 commits into from
Jun 10, 2020

Conversation

yuanming-hu
Copy link
Member

@yuanming-hu yuanming-hu commented Jun 10, 2020

Related issue = #1178

A quick hack to bring down the test case in #1178 from 6ms back to 1.6ms.

This can be removed once the WholeKernelCSE pass is back. Note that without WholeKernelCSE taichi_elements is still very slow.

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #1203 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1203   +/-   ##
=======================================
  Coverage   66.85%   66.85%           
=======================================
  Files          35       35           
  Lines        4827     4827           
  Branches      885      885           
=======================================
  Hits         3227     3227           
  Misses       1424     1424           
  Partials      176      176           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f759620...7cad77d. Read the comment docs.

Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yuanming-hu yuanming-hu merged commit e5cbf47 into taichi-dev:master Jun 10, 2020
@yuanming-hu yuanming-hu mentioned this pull request Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants