Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Opt] [ir] [refactor] Remove exceptions from IR check_out_of_bound and constant_fold #1251

Merged
merged 2 commits into from
Jun 16, 2020
Merged

[Opt] [ir] [refactor] Remove exceptions from IR check_out_of_bound and constant_fold #1251

merged 2 commits into from
Jun 16, 2020

Conversation

TH3CHARLie
Copy link
Collaborator

@TH3CHARLie TH3CHARLie marked this pull request as draft June 15, 2020 12:00
@TH3CHARLie TH3CHARLie changed the title [Opt] [ir] [refactor] Remove exceptions from IR passes [Opt] [ir] [refactor] Remove exceptions from IR passes Jun 15, 2020
@codecov
Copy link

codecov bot commented Jun 15, 2020 •
edited
Loading

Codecov Report

Merging #1251 into master will decrease coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1251      +/-   ##
==========================================
- Coverage   65.36%   64.79%   -0.57%     
==========================================
  Files          36       36              
  Lines        5041     5048       +7     
  Branches      922      921       -1     
==========================================
- Hits         3295     3271      -24     
- Misses       1570     1602      +32     
+ Partials      176      175       -1
Impacted Files Coverage Δ
python/taichi/misc/image.py 45.94% <0.00%> (-21.63%) ⬇️
python/taichi/lang/util.py 51.82% <0.00%> (-9.76%) ⬇️
python/taichi/main.py 41.45% <0.00%> (-0.34%) ⬇️
python/taichi/lang/kernel.py 78.70% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112f18e...9d68e1f. Read the comment docs.

@xumingkuan
Copy link
Contributor

I just took a look -- check_out_of_bound and constant_fold's refactoring looks simple enough so that it's fine to merge several passes like this at one time. But passes like simplify would be rather complicated, and that should be a single PR.

@TH3CHARLie TH3CHARLie changed the title [Opt] [ir] [refactor] Remove exceptions from IR passes [Opt] [ir] [refactor] Remove exceptions from IR check_out_of_bound and constant_fold Jun 16, 2020
@TH3CHARLie TH3CHARLie marked this pull request as ready for review June 16, 2020 00:53
xumingkuan
xumingkuan approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@xumingkuan xumingkuan merged commit 3dfcd37 into taichi-dev:master Jun 16, 2020
@FantasyVR FantasyVR mentioned this pull request Jun 17, 2020
Merged
@xumingkuan xumingkuan mentioned this pull request Jun 17, 2020
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xumingkuan xumingkuan xumingkuan approved these changes

@archibate archibate archibate approved these changes

@yuanming-hu yuanming-hu Awaiting requested review from yuanming-hu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TH3CHARLie @xumingkuan @archibate