Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf] Refactor kernel profiler #1261

Merged
merged 3 commits into from
Jun 17, 2020

Conversation

yuanming-hu
Copy link
Member

Related issue = #1178

We have two independent profiling system:

  • ProfilerBase that has flat records on kernel launches on devices
  • ScopedProfiler that has a hierarchical structure for host tasks (JIT etc.)

In this PR,

  • ProfilerBase now renamed to KernelProfilerBase to distinguish it from the scoped profiler (e.g. TI_AUTO_PROF)
  • Removed GUI::ProfilerBased *. In the future if profiling is needed we should use the scoped profiler there.
  • Restored CUDA event-based profiling

[Click here for the format server]


@yuanming-hu yuanming-hu requested review from k-ye and xumingkuan June 16, 2020 22:27
Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #1261 into master will increase coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1261      +/-   ##
==========================================
+ Coverage   84.81%   84.86%   +0.05%     
==========================================
  Files          18       18              
  Lines        3273     3271       -2     
  Branches      615      613       -2     
==========================================
  Hits         2776     2776              
  Misses        360      360              
+ Partials      137      135       -2     
Impacted Files Coverage Δ
python/taichi/lang/__init__.py 73.13% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7738915...1ce2d46. Read the comment docs.

@yuanming-hu yuanming-hu merged commit a493339 into taichi-dev:master Jun 17, 2020
@FantasyVR FantasyVR mentioned this pull request Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants