Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Opt] [ir] [refactor] Remove exceptions from DIE pass #1262

Merged
merged 2 commits into from
Jun 17, 2020

Conversation

TH3CHARLie
Copy link
Collaborator

Related issue = #1059

This is the only pass remained that can be modified simply, the others would require making changes to DelayedIRModifier(adding functions like replace_with). I'll make them in another PR.

[Click here for the format server]


Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Maybe also make die return if it modifies the IR so that passes like full_simplify can have a better sense of whether the IR is changed?

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #1262 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1262      +/-   ##
==========================================
+ Coverage   84.78%   84.86%   +0.07%     
==========================================
  Files          18       18              
  Lines        3267     3271       +4     
  Branches      613      613              
==========================================
+ Hits         2770     2776       +6     
  Misses        360      360              
+ Partials      137      135       -2     
Impacted Files Coverage Δ
python/taichi/lang/__init__.py 73.13% <0.00%> (+0.43%) ⬆️
python/taichi/lang/snode.py 77.33% <0.00%> (+1.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 035bcb9...6a3b55a. Read the comment docs.

@TH3CHARLie TH3CHARLie requested a review from xumingkuan June 17, 2020 02:58
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks. Let's merge this after v0.6.11 is released. @xumingkuan Feel free to merge IR-optimization related PRs without my approval - you understand this part very well and I trust your decision.

Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xumingkuan xumingkuan merged commit b2f4bfc into taichi-dev:master Jun 17, 2020
@FantasyVR FantasyVR mentioned this pull request Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants