-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Opt] [ir] [refactor] Remove exceptions from DIE pass #1262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Maybe also make die
return if it modifies the IR so that passes like full_simplify
can have a better sense of whether the IR is changed?
Codecov Report
@@ Coverage Diff @@
## master #1262 +/- ##
==========================================
+ Coverage 84.78% 84.86% +0.07%
==========================================
Files 18 18
Lines 3267 3271 +4
Branches 613 613
==========================================
+ Hits 2770 2776 +6
Misses 360 360
+ Partials 137 135 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks. Let's merge this after v0.6.11 is released. @xumingkuan Feel free to merge IR-optimization related PRs without my approval - you understand this part very well and I trust your decision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Related issue = #1059
This is the only pass remained that can be modified simply, the others would require making changes to
DelayedIRModifier
(adding functions likereplace_with
). I'll make them in another PR.[Click here for the format server]