[Opt] [refactor] Move unreachable code elimination to a separate pass #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xumingkuan
changed the title
|
BTW Shall we add optimizations for |
Codecov Report
@@ Coverage Diff @@
## master #1315 +/- ##
=======================================
Coverage 86.14% 86.14%
=======================================
Files 18 18
Lines 3313 3313
Branches 622 622
=======================================
Hits 2854 2854
Misses 333 333
Partials 126 126 Continue to review full report at Codecov.
|
yuanming-hu
approved these changes
Jun 24, 2020
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
So I think I should add the optimization into this pass, and rename the pass |
xumingkuan
changed the title
xumingkuan
added a commit
to xumingkuan/taichi
that referenced
this pull request
Jun 24, 2020
xumingkuan
added a commit
that referenced
this pull request
Jun 24, 2020
Merged
Rullec
pushed a commit
to Rullec/taichi
that referenced
this pull request
Jun 26, 2020
…taichi-dev#1315) * [Opt] [refactor] Move unreachable code elimination to a separate pass * improve * minor * [skip ci] minor * Update taichi/transforms/continue_stmt_optimization.cpp Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com> * add optimizations for if (0) and if (1) Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
Rullec
pushed a commit
to Rullec/taichi
that referenced
this pull request
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #656
Related PR = #1299
I did this refactoring because the optimization about
ContinueStmtinsimplifyI added in #1299 probably made removing the exceptions (#1059) in that pass more difficult.Although the function of this pass is similar to the
DIEpass, the logic is completely different. So I put it in a separate pass. We can eliminateContinueStmts like the following in this PR:I'm not sure about how this pass should be named, so feel free to propose better names.
[Click here for the format server]