[metal] Refactor runtime ListManager utils #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1444 +/- ##
==========================================
+ Coverage 85.05% 85.42% +0.36%
==========================================
Files 20 20
Lines 3473 3485 +12
Branches 638 632 -6
==========================================
+ Hits 2954 2977 +23
+ Misses 389 382 -7
+ Partials 130 126 -4
Continue to review full report at Codecov.
|
yuanming-hu
approved these changes
Jul 11, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just moves some util functions into
ListManageras its member functions. This is a cleanup in prep forNodeManager.Again, please ignore the formatter suggestion, if there is any. They tend to mess up these
.metal.hfiles..Related issue = #1174
[Click here for the format server]