-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] Support GCC as compiler for Taichi developers (experimental) #1598
Conversation
else() | ||
message("Invalid compiler ${CMAKE_CXX_COMPILER_ID} detected.") | ||
message(FATAL_ERROR "clang and MSVC are the only supported compilers for Taichi compiler development. Consider using 'cmake -DCMAKE_CXX_COMPILER=clang' if you are on Linux") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update this message and doc when GCC is battle-tested.
Codecov Report
@@ Coverage Diff @@
## master #1598 +/- ##
==========================================
+ Coverage 86.76% 86.87% +0.11%
==========================================
Files 19 19
Lines 3679 3689 +10
Branches 653 654 +1
==========================================
+ Hits 3192 3205 +13
+ Misses 354 350 -4
- Partials 133 134 +1
Continue to review full report at Codecov.
|
It would be great if GCC is supported.
For this, I think maybe adding another build(possibly: master build, ubuntu, GCC and 3.7) to monitor and also show the effect of GCC. Since GCC support is now experimental, the build can be set to allow failure. It can happen within this PR or in a separate one, either way, having this would enable all taichi developers to monitor GCC progress and have a better context on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
It's worth mentioning that if someone uses the LLVM backend for development, clang
is still needed to compile the runtime bitcode.
I guess you are trying to use the cc
backend with gcc (and therefore you don't need the LLVM backend?)
It's nice that we can compile Taichi with gcc
. Feel free to merge if it works on your end.
Yes, but note that we don't need
Yes, that's my point: to allow contributors build and test on
Yes, that's cool and many examples are functional! But some tests involving advanced features failed, maybe it's |
Thanks. All sounds good to me.
I think it's a good idea to add that flag. I do it when I have time, but I'm probably slow given my recent schedule. It can be a nice newcomer issue. Maybe we should open an issue and let new contributors help with that?
It's great that many examples are working! I'd suggest we do that in a different PR. Small PRs are always good. |
Related issue = #
[Click here for the format server]
IMO, GCC vs Clang ~= OpenGL vs CUDA: despite Clang is more fit with LLVM, but GCC is distributed on almost all *nix machines, we may also add mingw64 support later instead of the ad-hoc MSVC which is embed into that gaint IDE..
It also provides many useful warnings (much more than Clang) that might help us debug our C++ program.