[misc] [refactor] 'ti.vec' and 'ti.veci' is deprecated, directly use a tuple in GUI system instead #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vec' and 'ti.core_veci' instead
archibate
changed the title
IhostVlad
approved these changes
Jul 30, 2020
yuanming-hu
approved these changes
Jul 31, 2020
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #1605 +/- ##
==========================================
+ Coverage 86.81% 86.87% +0.06%
==========================================
Files 19 19
Lines 3685 3689 +4
Branches 653 654 +1
==========================================
+ Hits 3199 3205 +6
+ Misses 353 350 -3
- Partials 133 134 +1
Continue to review full report at Codecov.
|
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #
[Click here for the format server]
Since some beginners may confuse
ti.vecas an alias forti.Vector... liketaichi_glsl.vecdoes.Let's rename it to
core_vecsince it's a class exported fromlibtaichi_core.so, any suggestion on the name?Let's remove it as soon as possible before v0.7.0, since our GUI system is already wrapped by Python and able to take tuple as input.
I used the
@deprecatedmark instead of fully deprecate it because, I see some DiffTaichi examples are still using them in GUI system. @yuanming-hu Could you upgrade DiffTaichi to new syntax (including this change and others)? I found most of them are not able to run now 😕OFT: doc
ti.rgb_to_hex.