-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GUI] Support images with 2 channels (RG) in GUI.set_image #1624
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1624 +/- ##
==========================================
+ Coverage 45.06% 45.07% +0.01%
==========================================
Files 40 41 +1
Lines 5790 5766 -24
Branches 1012 1053 +41
==========================================
- Hits 2609 2599 -10
+ Misses 3032 3009 -23
- Partials 149 158 +9
Continue to review full report at Codecov.
|
LGTM! |
In fact we are always using RGBA as internal format storing in our GUI module, no matter grayscale, RG or RGB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thanks, @archibate
Co-authored-by: Xiao Zhai <7610945+TroyZhai@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks 🧀
Related issue = #
[Click here for the format server]
This could be handy when visualizing 2D vector fields, e.g.: velocity field in
stable_fluid.py
.