Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cc] Compose ActionRecorder outputs into a single C file for Emscripten #1629
[cc] Compose ActionRecorder outputs into a single C file for Emscripten #1629
Changes from 11 commits
6ae8c7e
a4eba6c
b7d1c66
57f4385
6855515
b49d00e
0f55f59
0ee7da0
0eeca93
230b22e
2a4fceb
71bc7b5
1b32545
9702a22
05f7dfa
914b2fb
d25cbea
5ec8dc6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still people using information like
set_kernel_arg_int64
. Can we keep these for now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it doesn't even include
dtype
... They are just spams in our compile-only no-launch action parser, both in CC and [数据删除] in my pratice...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But there are still people depending on this. I don't think we should remove them immediately. Maybe a better solution is to mark them as a different type of message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the feature is
purposely undocumented
and used by only you and me and the [数据删除]? Also did you confirmed this doesn't harm performance? IMO we'd remove all the run-time action output iapr, since only compile-time kernel information are required for reconstructing a Taichi program outside, e.g., this PR, did that easily.