Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[workflow] Add Mac OS X to Github CI #1649

Merged
merged 8 commits into from
Aug 7, 2020
Merged

[workflow] Add Mac OS X to Github CI #1649

merged 8 commits into from
Aug 7, 2020

Conversation

archibate
Copy link
Collaborator

@archibate archibate requested a review from yuanming-hu August 5, 2020 15:48
@archibate archibate requested a review from k-ye August 5, 2020 15:53
@archibate archibate marked this pull request as ready for review August 5, 2020 15:56
@codecov
Copy link

codecov bot commented Aug 5, 2020 •
edited
Loading

Codecov Report

Merging #1649 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1649   +/-   ##
=======================================
  Coverage   44.40%   44.40%           
=======================================
  Files          41       41           
  Lines        5876     5876           
  Branches     1022     1022           
=======================================
  Hits         2609     2609           
  Misses       3118     3118           
  Partials      149      149

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29071b3...4e05b44. Read the comment docs.

@archibate archibate requested a review from xumingkuan August 5, 2020 16:42
@archibate archibate requested a review from TH3CHARLie August 7, 2020 04:12
TH3CHARLie
TH3CHARLie approved these changes Aug 7, 2020
View reviewed changes
Copy link
Collaborator

@TH3CHARLie TH3CHARLie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@archibate archibate added the LGTM label Aug 7, 2020
@archibate
Copy link
Collaborator Author

@yuanming-hu Merging this so that I could go forward to win GHCI, ff2 revert me if you got fatal drawback.

@archibate archibate merged commit e2b5c5b into taichi-dev:master Aug 7, 2020
@yuanming-hu yuanming-hu mentioned this pull request Aug 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TH3CHARLie TH3CHARLie TH3CHARLie approved these changes

@yuanming-hu yuanming-hu Awaiting requested review from yuanming-hu

@k-ye k-ye Awaiting requested review from k-ye

@xumingkuan xumingkuan Awaiting requested review from xumingkuan

Assignees

@yuanming-hu yuanming-hu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@archibate @TH3CHARLie @yuanming-hu