Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] [cc] Doc the workflow for exporting Taichi kernels to C99 source #1756

Merged
merged 16 commits into from
Sep 3, 2020

Conversation

archibate
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #1756 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1756      +/-   ##
==========================================
- Coverage   43.64%   43.63%   -0.01%     
==========================================
  Files          44       44              
  Lines        6051     5940     -111     
  Branches     1083     1071      -12     
==========================================
- Hits         2641     2592      -49     
+ Misses       3255     3195      -60     
+ Partials      155      153       -2     
Impacted Files Coverage Δ
python/taichi/cc_compose.py 0.00% <0.00%> (ø)
python/taichi/main.py 23.91% <0.00%> (+0.50%) ⬆️
python/taichi/lang/kernel.py 70.22% <0.00%> (-0.96%) ⬇️
python/taichi/misc/util.py 17.17% <0.00%> (-0.58%) ⬇️
python/taichi/code_format.py 12.00% <0.00%> (-0.38%) ⬇️
python/taichi/lang/transformer.py 81.61% <0.00%> (-0.28%) ⬇️
python/taichi/lang/common_ops.py 69.04% <0.00%> (-0.22%) ⬇️
python/taichi/lang/impl.py 66.76% <0.00%> (-0.09%) ⬇️
python/taichi/diagnose.py 0.00% <0.00%> (ø)
python/taichi/misc/gui.py 0.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ee1975...7d897be. Read the comment docs.

docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
Co-authored-by: Xudong Feng <xudongfeng1996@gmail.com>
@archibate archibate requested a review from Rullec August 24, 2020 15:26
@k-ye
Copy link
Member

k-ye commented Aug 26, 2020

Will this be most helpful to @samuela (#1642)? If so, better inviting him to help take a look?

Copy link
Contributor

@samuela samuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together @archibate ! My one big-picture comment is that it'd be nice to also include a note on which Taichi features are and are not supported by the C backend at the moment. Eg, my understanding is that the AD stack does not yet work with the C backend, but that most other things do. Another question is whether it's possible for the C backend to output code CUDA-compatible code.

docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
@archibate archibate requested a review from rexwangcc August 28, 2020 04:17
@archibate archibate mentioned this pull request Aug 28, 2020
9 tasks
@archibate archibate added refactor Refactor of API or codebases and removed refactor Refactor of API or codebases labels Aug 28, 2020
Copy link
Collaborator

@rexwangcc rexwangcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments around wording, thank you for updating the documentation for CC backend, so excited!

docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/snode.rst Outdated Show resolved Hide resolved
Co-authored-by: Chengchen(Rex) Wang <14366016+rexwangcc@users.noreply.github.com>
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I can't wait to try it. Please fix the minor wording issues. Thank you so much!

docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
docs/export_kernels.rst Outdated Show resolved Hide resolved
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM now. Thank you very much!

@archibate archibate added LGTM and removed skip ci labels Sep 3, 2020
@archibate archibate merged commit de26d08 into taichi-dev:master Sep 3, 2020
@yuanming-hu yuanming-hu mentioned this pull request Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants