-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] [cc] Doc the workflow for exporting Taichi kernels to C99 source #1756
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1756 +/- ##
==========================================
- Coverage 43.64% 43.63% -0.01%
==========================================
Files 44 44
Lines 6051 5940 -111
Branches 1083 1071 -12
==========================================
- Hits 2641 2592 -49
+ Misses 3255 3195 -60
+ Partials 155 153 -2
Continue to review full report at Codecov.
|
Co-authored-by: Xudong Feng <xudongfeng1996@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together @archibate ! My one big-picture comment is that it'd be nice to also include a note on which Taichi features are and are not supported by the C backend at the moment. Eg, my understanding is that the AD stack does not yet work with the C backend, but that most other things do. Another question is whether it's possible for the C backend to output code CUDA-compatible code.
Co-authored-by: Samuel Ainsworth <skainsworth@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments around wording, thank you for updating the documentation for CC backend, so excited!
Co-authored-by: Chengchen(Rex) Wang <14366016+rexwangcc@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I can't wait to try it. Please fix the minor wording issues. Thank you so much!
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! LGTM now. Thank you very much!
Related issue = #920 #1644
[Click here for the format server]