-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[error] [doc] Better error message when X11 environment failed to initialize #1856
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1856 +/- ##
==========================================
+ Coverage 43.25% 44.21% +0.95%
==========================================
Files 44 44
Lines 6320 6111 -209
Branches 1092 1092
==========================================
- Hits 2734 2702 -32
+ Misses 3416 3240 -176
+ Partials 170 169 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for moving the fps stuff!
cf8b55c
to
66e0638
Compare
@yuanming-hu Can we use an
LHS for non-gardener final-commit, RS for gardener final-commit, which always fix the code format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM. Just one wording nit.
@yuanming-hu Can we use an
or
parse in this 'required statuses` mechanism? I.e.
(Build and Test && Code format) || Checks the Workflow Run of the Previous Commit
LHS for non-gardener final-commit, RS for gardener final-commit, which always fix the code format.
GitHub doesn't provide that option, unfortunately...
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
Related issue = #1817
[Click here for the format server]