Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[async] Draw nodes as record shape, allow embedding states into nodes #1876

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Sep 16, 2020

Sorry to put additional burdens on you guys... Thought you preferred the rectangular shape a bit more. I also allowed states to be embedded into the nodes, if the number of states is below a certain threshold (default to 0).

  • fusion_0000_initial

Screen Shot 2020-09-16 at 22 18 02

  • fusion_0000_initial embedded

Screen Shot 2020-09-16 at 22 17 50

  • fusion_0003_dse

Screen Shot 2020-09-16 at 22 18 31

  • fusion_0003_dse embedded

Screen Shot 2020-09-16 at 22 18 21

Related issue = N/A

[Click here for the format server]


@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #1876 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1876   +/-   ##
=======================================
  Coverage   44.21%   44.21%           
=======================================
  Files          44       44           
  Lines        6111     6111           
  Branches     1092     1092           
=======================================
  Hits         2702     2702           
  Misses       3240     3240           
  Partials      169      169           
Impacted Files Coverage Δ
python/taichi/misc/util.py 17.48% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b8770...1b4bb18. Read the comment docs.

Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! LGTM.

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you.

@yuanming-hu yuanming-hu merged commit 7fac30f into taichi-dev:master Sep 16, 2020
@yuanming-hu yuanming-hu mentioned this pull request Sep 16, 2020
@k-ye k-ye deleted the dot branch October 18, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants