[async] Optimize StateFlowGraph::optimize_listgen #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1894 +/- ##
=======================================
Coverage 43.81% 43.81%
=======================================
Files 45 45
Lines 6174 6174
Branches 1097 1097
=======================================
Hits 2705 2705
Misses 3300 3300
Partials 169 169 Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #742
StateFlowGraph::optimize_listgennow does more job each iteration. Previously it very conservativelybreaks after modifying a single SFG node. This change also seems to eliminate moreClearListStmtfor some reason. After this changeoptimize_listgenis ~2x faster on mgpcg.Offtopic change: the CUDA profiler now returns a handle when calling
start_with_handle(). We need the handle (which is essentially a CUDA event pointer) to mark the end of a kernel launch.[Click here for the format server]