Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf] Wrap clear loss/grad into a kernel #1902

Merged
merged 1 commit into from
Sep 27, 2020
Merged

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Sep 27, 2020

Let me submit this part first. With this simple tweak MPM lagrangian force on my end already runs from 15fps to 24fps...

Related issue = #N/A

[Click here for the format server]


@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #1902 into master will increase coverage by 0.98%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1902      +/-   ##
==========================================
+ Coverage   42.87%   43.86%   +0.98%     
==========================================
  Files          45       45              
  Lines        6397     6190     -207     
  Branches     1099     1099              
==========================================
- Hits         2743     2715      -28     
+ Misses       3484     3306     -178     
+ Partials      170      169       -1     
Impacted Files Coverage Δ
python/taichi/lang/__init__.py 42.46% <100.00%> (-0.51%) ⬇️
python/taichi/lang/meta.py 64.38% <100.00%> (+1.52%) ⬆️
python/taichi/lang/ast_checker.py 70.58% <0.00%> (-1.64%) ⬇️
python/taichi/testing.py 75.00% <0.00%> (-0.72%) ⬇️
python/taichi/lang/linalg.py 89.33% <0.00%> (-0.67%) ⬇️
python/taichi/misc/util.py 18.27% <0.00%> (-0.24%) ⬇️
python/taichi/misc/task.py 0.00% <0.00%> (ø)
python/taichi/tools/patterns.py 0.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0ac1d8...10fcb9c. Read the comment docs.

Copy link
Collaborator

@archibate archibate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for make Taichi.js export process a bit easier!

@k-ye k-ye merged commit 62ec3ac into taichi-dev:master Sep 27, 2020
@k-ye k-ye deleted the no-write-loss branch September 27, 2020 11:25
@yuanming-hu yuanming-hu mentioned this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants