Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[async] Add advection benchmark #1914

Merged
merged 9 commits into from
Oct 1, 2020
Merged

[async] Add advection benchmark #1914

merged 9 commits into from
Oct 1, 2020

Conversation

yuanming-hu
Copy link
Member

Related issue = #

  • Added advection_2d
  • Reduced data size of async benchmark cases by 10x since now we have IRHandles
  • Added device_time recording

[Click here for the format server]

@codecov
Copy link

codecov bot commented Oct 1, 2020 •
edited
Loading

Codecov Report

Merging #1914 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1914      +/-   ##
==========================================
- Coverage   43.86%   43.83%   -0.03%     
==========================================
  Files          45       45              
  Lines        6190     6194       +4     
  Branches     1099     1100       +1     
==========================================
  Hits         2715     2715              
- Misses       3306     3310       +4     
  Partials      169      169
Impacted Files Coverage Δ
python/taichi/lang/__init__.py 42.11% <0.00%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aeff7c...0305778. Read the comment docs.

k-ye
k-ye approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

xumingkuan
xumingkuan approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit!

benchmarks/async_advection.py Show resolved Hide resolved
@yuanming-hu yuanming-hu merged commit 75d5ecc into taichi-dev:master Oct 1, 2020
@yuanming-hu yuanming-hu mentioned this pull request Oct 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xumingkuan xumingkuan xumingkuan approved these changes

@k-ye k-ye k-ye approved these changes

@taichi-gardener taichi-gardener Awaiting requested review from taichi-gardener

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuanming-hu @k-ye @xumingkuan